-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Run batch execution after session starts #2327
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
82d6f94
to
75e93a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm... in my setup, it seems not working well. Investigating more.
- Missing session events in the event stream (only kernel events)
- According to the manager log, "SessionStarted" event is fired.
- There is no way to check if the batch execution task is actually running or not. The container log shows nothing?
Update:
After restarting my dev services, it seems to work as expected, except that SessionStarted
events are often missing. 🤔
…ssion-starts' into fix/run-batch-execution-after-session-starts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to retrigger the execution of the startup command when we restart the session. See the tail of AgentRegistry.restart_session()
method.
Co-authored-by: Joongi Kim <[email protected]> Backported-from: main (24.09) Backported-to: 24.03 Backport-of: 2327
Co-authored-by: Sanghun Lee <[email protected]> Co-authored-by: Joongi Kim <[email protected]>
resolves #2326
How the lifetime of the batch session changes
RUNNING
, it callssrc.ai.backend.manager.registry.trigger_batch_execution()
API.trigger_batch_execution()
RPC function to an agent where a main kernel is allocated.SessionSuccess
event when the batch execution finishes and a manager that consumes the event destroys the batch session.Checklist: (if applicable)